Purpose

This PR fixes issue #97.

Additions

Added land cover and soil consistency checks to initialize_from_file in RunModule.f90. These checks throw an error and stop the program if any cell is initialized with the following conditions:

• land use type != water and soil type = water
• land use type = water and soil type != water
• land use type != ice and soil type = ice
• land use type = ice and soil type != ice

Testing

I manually/hardcoded problematic values for vegtyp and isltyp to produce errors:

where (domaingrid%mask.eq.1) domaingrid%vegtyp = parametersgrid%ISWATER
where (domaingrid%mask.eq.1) domaingrid%isltyp = 1
returns => ERROR: one or more grid cells have a water land cover (vegtyp = 16) and a non-water soil type (isltyp != 14)

where (domaingrid%mask.eq.1) domaingrid%vegtyp = 1
where (domaingrid%mask.eq.1) domaingrid%isltyp = 14
returns => ERROR: one or more grid cells have a non-water land cover (vegtyp != 16) and a water soil type (isltyp = 14)

where (domaingrid%mask.eq.1) domaingrid%vegtyp = parametersgrid%ISICE
where (domaingrid%mask.eq.1) domaingrid%isltyp = 1
returns => ERROR: one or more grid cells have an ice land cover (vegtyp = 24) and a non-ice soil type (isltyp != 16)

where (domaingrid%mask.eq.1) domaingrid%vegtyp = 1
where (domaingrid%mask.eq.1) domaingrid%isltyp = 16
returns => ERROR: one or more grid cells have a non-ice land cover (vegtyp != 24) and an ice soil type (isltyp = 16)

Notes

• Implemented checks using where statements to avoid iterating over the grid
• Checks were implemented with hardcoded water and ice values for soil type. To avoid using hardcoded soil type values, we could require that the user provide ISWATER and ISICE values for the utilized soil classification scheme (as the user already must provide for the utilized land cover classification scheme).